[libvirt] [PATCH 2/4] parallels: don't enable VNC when we define a new domain
I added this code year ago, instead of implementing ability
to change VNC configuration, which was not trivial, I added
extra call to prlctl, which sets up VNC with auto port, despite
VNC configuration given by a user.
Let's remove this hack, because, first, it doesn't work on the
latest Parallels Cloud Server release (you have to either specify
--vnc-nopasswd option or password). And also has problem with
error handling. If second call to prlctl fails, VM, created by
first call to prlctl, will not be removed.
Signed-off-by: Dmitry Guryanov <dguryanov(a)parallels.com>
---
src/parallels/parallels_driver.c | 6 ------
1 file changed, 6 deletions(-)
diff --git a/src/parallels/parallels_driver.c b/src/parallels/parallels_driver.c
index 41bb34b..1c58b45 100644
--- a/src/parallels/parallels_driver.c
+++ b/src/parallels/parallels_driver.c
@@ -2258,9 +2258,6 @@ parallelsCreateVm(virConnectPtr conn, virDomainDefPtr def)
"--uuid", uuidstr, NULL) < 0)
goto error2;
- if (parallelsCmdRun(PRLCTL, "set", def->name, "--vnc-mode",
"auto", NULL) < 0)
- goto error2;
-
virStoragePoolObjUnlock(pool);
virObjectUnref(vol);
@@ -2294,9 +2291,6 @@ parallelsCreateCt(virConnectPtr conn ATTRIBUTE_UNUSED,
virDomainDefPtr def)
"--ostemplate", def->fss[0]->src, NULL) < 0)
goto error;
- if (parallelsCmdRun(PRLCTL, "set", def->name, "--vnc-mode",
"auto", NULL) < 0)
- goto error;
-
return 0;
error:
--
1.9.0