[libvirt] [PATCH 14/20] Remove PATH_MAX sized stack allocation from virFileOpenTtyAt

Sunday, 3 April 2011

---
 src/util/util.c |    9 ++++-----
 1 files changed, 4 insertions(+), 5 deletions(-)

diff --git a/src/util/util.c b/src/util/util.c
index 31feecc..c0391ad 100644
--- a/src/util/util.c
+++ b/src/util/util.c
@@ -1901,14 +1901,13 @@ int virFileOpenTtyAt(const char *ptmx,
     }
 
     if (ttyName) {
-        char tempTtyName[PATH_MAX];
-        if (ptsname_r(*ttymaster, tempTtyName, sizeof(tempTtyName)) < 0)
-            goto cleanup;
-
-        if ((*ttyName = strdup(tempTtyName)) == NULL) {
+        if (VIR_ALLOC_N(*ttyName, PATH_MAX) < 0) {
             errno = ENOMEM;
             goto cleanup;
         }
+
+        if (ptsname_r(*ttymaster, *ttyName, PATH_MAX) < 0)
+            goto cleanup;
     }
 
     rc = 0;
-- 
1.7.0.4


    