Re: [libvirt] [PATCH] Set default name for SPICE agent channel

On 03/23/2012 04:08 AM, Christophe Fergeau wrote: > libvirt documentation for channels with type 'spicevmc' says that the > 'target' child node has: > "an optional attribute name controls how the guest will have access > to the channel, and defaults to name='com.redhat.spice.0'." > > However, this default value is never set in libvirt code base, > there's only a check in qemu_command.c to error out if the name > attribute doesn't have the expected value (if it's set). > > This commit sets a default target name for spicevmc channels during > the domain configuration parsing so that the code agrees with the > documentation. > --- > src/conf/domain_conf.c | 7 +++++++ > 1 files changed, 7 insertions(+), 0 deletions(-) ACK, and okay to push before 0.9.11. > } else { > def->source.data.spicevmc = VIR_DOMAIN_CHR_SPICEVMC_VDAGENT; > + if (!def->target.name) { > + def->target.name = strdup("com.redhat.spice.0"); > + if (!def->target.name) { > + virReportOOMError(); > + goto error; > + } > + } > } > } >