Re: [libvirt] [PATCH 3/4] build: .service files don't need to be executable

See also commit 66ff2dd, where we avoided installing these files as executables. * daemon/Makefile.am (libvirtd.service): Drop chmod. * tools/Makefile.am (libvirt-guests.service): Likewise. * src/Makefile.am (virtlockd.service, virtlockd.socket): Likewise. --- daemon/Makefile.am | 1 - src/Makefile.am | 2 -- tools/Makefile.am | 1 - 3 files changed, 4 deletions(-)

diff --git a/daemon/Makefile.am b/daemon/Makefile.am index 60112ff..7bcc7e2 100644 --- a/daemon/Makefile.am +++ b/daemon/Makefile.am @@ -354,7 +354,6 @@ libvirtd.service: libvirtd.service.in $(top_builddir)/config.status -e 's|[@]sbindir[@]|$(sbindir)|g' \ -e 's|[@]sysconfdir[@]|$(sysconfdir)|g' \ < $< > $@-t && \ - chmod a+x $@-t && \ mv $@-t $@ diff --git a/src/Makefile.am b/src/Makefile.am index ba685bb..08611fb 100644 --- a/src/Makefile.am +++ b/src/Makefile.am @@ -1709,14 +1709,12 @@ virtlockd.service: locking/virtlockd.service.in $(top_builddir)/config.status $(AM_V_GEN)sed \ -e 's|[@]sbindir[@]|$(sbindir)|g' \ < $< > $@-t && \ - chmod a+x $@-t && \ mv $@-t $@ virtlockd.socket: locking/virtlockd.socket.in $(top_builddir)/config.status $(AM_V_GEN)sed \ -e 's|[@]localstatedir[@]|$(localstatedir)|g' \ < $< > $@-t && \ - chmod a+x $@-t && \ mv $@-t $@ diff --git a/tools/Makefile.am b/tools/Makefile.am index 58dbfe7..3775914 100644 --- a/tools/Makefile.am +++ b/tools/Makefile.am @@ -260,7 +260,6 @@ libvirt-guests.service: libvirt-guests.service.in $(top_builddir)/config.status -e 's|[@]sysconfdir[@]|$(sysconfdir)|g' \ -e 's|[@]libexecdir[@]|$(libexecdir)|g' \ < $< > $@-t && \ - chmod a+x $@-t && \ mv $@-t $@