On 12/23/2010 04:16 PM, Laine Stump wrote:
I squashed in all of Eric's recommendations and pushed this
entire
series.
The networkApplyTest.sh of the libvirt tck test suite does not pass
anymore. I assume it's due to the changes in this part of the code. I
see the following change on the broadcast address of the interface:
sh ./networkApplyTest.sh --wait --verbose --force
FAIL networkxml2xmlin/tck-testnet-2.xml : ifconfig tck-testbr | grep
':10\.1\.2\.'
1c1
< inet addr:10.1.2.1 Bcast:0.0.0.0 Mask:255.255.255.0
---
inet addr:10.1.2.1 Bcast:10.1.2.255 Mask:255.255.255.0
The Bcast address is now set to 0.0.0.0 and is expected to be 10.1.2.255.
Stefan
Thanks for the great reviews Eric!
On 12/22/2010 01:57 PM, Laine Stump wrote:
> This is a resend of
>
>
>
https://www.redhat.com/archives/libvir-list/2010-December/msg00765.html
>
> incorporating changes due to comments from Eric Blake and Paweł
> Krześniak.
>
> changes from v1 to v2 are noted in each individual mail
>
> -----
> Most of this patchset is setup for patch 09/13, which updates the
> network XML parser to support IPv6, and 12/13, which turns on IPv6 in
> the bridge driver.
>
> In order to have each patch individually pass make check and
> (otherwise function properly in case someone is doing a bisect), there
> is a bit of extra code churn (lines that are changed in one patch,
> only to be changed again in a later patch); I tried to minimize this
> as much as possible.
>
> For for IPv6 to work correctly, target *and build* systems will
> now need to have ip6tables and radvd available. The way I added
> ip6tables into autoconfigure.ac is identical to existing iptables, and
> the way I added radvd is identical to dnsmasq. Unfortunately this
> doesn't communicate the requirement downstream in a programmatic
> fashion, so I guess we need to make sure that this is adequately
> reported in the next set of release notes.
>
> --
> libvir-list mailing list
> libvir-list(a)redhat.com
>
https://www.redhat.com/mailman/listinfo/libvir-list
--
libvir-list mailing list
libvir-list(a)redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list