Re: [libvirt] [PATCHv2 1/7] qemu: Forbid setting maximum memory size with the API with NUMA enabled

On Wed, Feb 25, 2015 at 11:21:58AM +0100, Peter Krempa wrote: s/decrease/change/ as I believe increase isn't possible as well. ACK with this squashed in (or added flag that will proportionally change node memory sizes): diff --git i/src/qemu/qemu_driver.c w/src/qemu/qemu_driver.c index 471b583..60c97ad 100644 --- i/src/qemu/qemu_driver.c +++ w/src/qemu/qemu_driver.c @@ -2309,7 +2309,7 @@ static int qemuDomainSetMemoryFlags(virDomainPtr dom, unsigned long newmem, sa_assert(persistentDef); /* resizing memory with NUMA nodes specified doesn't work as there - * is no way to decrease the individual node sizes with this API */ + * is no way to changee individual node sizes with this API */ if (virDomainNumaGetNodeCount(persistentDef->numa) > 0) { virReportError(VIR_ERR_OPERATION_INVALID, "%s", _("maximum memory size of a domain with NUMA " diff --git i/tools/virsh.pod w/tools/virsh.pod index 343f26f..408cac5 100644 --- i/tools/virsh.pod +++ w/tools/virsh.pod @@ -1937,7 +1937,10 @@ exclusive. If no flag is specified, behavior is different depending on hypervisor. Some hypervisors such as QEMU/KVM don't support live changes (especially -increasing) of the maximum memory limit. +increasing) of the maximum memory limit. Even persistent configuration changes +might not be performed with some hypervisors/configuration (e.g. on NUMA enabled +domains on QEMU). For complex configuration changes use command B<edit> +instead). I<size> is a scaled integer (see B<NOTES> above); it defaults to kibibytes (blocks of 1024 bytes) unless you provide a suffix (and the older option --