Re: [libvirt] [PATCHv4 1/6] conf: add <ioapic driver> to <features>

On Tue, May 09, 2017 at 01:08:55PM +0200, Andrea Bolognani wrote: I have sent the capabilites as a separate patch. Re: x86-only: would squashing this in do? Jan diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c index cc02c80..7805b76 100644 --- a/src/qemu/qemu_domain.c +++ b/src/qemu/qemu_domain.c @@ -2807,6 +2807,22 @@ qemuDomainDefCPUPostParse(virDomainDefPtr def) static int +qemuDomainDefVerifyFeatures(const virDomainDef *def) +{ + if (def->features[VIR_DOMAIN_FEATURE_IOAPIC] == VIR_TRISTATE_SWITCH_ON && + !ARCH_IS_X86(def->os.arch)) { + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, + _("I/O APIC tuning is not supported " + "for '%s' architecture"), + virArchToString(def->os.arch)); + return -1; + } + + return 0; +} + + +static int qemuDomainDefPostParse(virDomainDefPtr def, virCapsPtr caps, unsigned int parseFlags, @@ -2861,6 +2877,9 @@ qemuDomainDefPostParse(virDomainDefPtr def, qemuDomainDefEnableDefaultFeatures(def, qemuCaps); + if (qemuDomainDefVerifyFeatures(def) < 0) + goto cleanup; + if (qemuDomainRecheckInternalPaths(def, cfg, parseFlags) < 0) goto cleanup;