Re: [libvirt PATCH 0/3] tests: Fix qemucapabilitiestest on macOS

On 2022-08-10 at 16:29 +02, Andrea Bolognani <abologna(a)redhat.com&gt; wrote... > We need to mock the function that probes for HVF support. > > Andrea Bolognani (3): > tests: Use domaincapsmock in qemucapabilitiestest > qemu: Make virQEMUCapsProbeHVF() non-static > tests: Mock virQEMUCapsProbeHVF() > > src/qemu/qemu_capabilities.c | 4 ++-- > src/qemu/qemu_capabilities.h | 2 ++ > tests/domaincapsmock.c | 6 ++++++ > tests/qemucapabilitiestest.c | 3 ++- > 4 files changed, 12 insertions(+), 3 deletions(-) This works. We now have a clean test suite on macOS 12: Ok: 252 Expected Fail: 0 Fail: 0 Unexpected Pass: 0 Skipped: 19 Timeout: 0 For the series: Reviewed-by: Christophe de Dinechin <dinechin(a)redhat.com&gt; Tested-by: Christophe de Dinechin <dinechin(a)redhat.com&gt;