Re: [libvirt] [PATCH v2 1/3] qemu: Make all SPICE command-line args optional
On Tue, May 17, 2016 at 12:11:38PM +0200, Christophe Fergeau wrote:
Hey,
After this patch series, the QEMU command line may not contain port nor
tls-port if they both were set to '0'. However, QEMU versions older than
2.3.0 will error out because they don't have this commit:
http://git.qemu.org/?p=qemu.git;a=commitdiff;h=cf7856adefebe86e0
From that snippet of code it seems omitting port completely and
setting
it to 0 were equivalent.
I assume we want to keep supporting older QEMU binaries, and that
this
needs to be fixed on libvirt side?
It seems this never worked with older QEMUs, regardless of this series.
Jan