Re: [libvirt] [PATCH] build: avoid variable named 'interface', for mingw
On 03/28/2015 04:26 PM, Eric Blake wrote:
Commit 2f36e6944 (re-)introduced a use of an identifier
'interface',
which causes this build failure on mingw:
../../tools/virsh-domain-monitor.c: In function 'cmdDomIfAddr':
../../tools/virsh-domain-monitor.c:2233:17: error: expected identifier or '('
before 'struct'
const char *interface = NULL;
^
See also commit 6512c8b.
And 1528e8b and 335f6bc2 and 1499e1d5f. This has caused problems since
2009 :-/
Sadly, I'm not quite sure how to write a
syntax check that can poison the use of this identifier.
Yeah. And it's hard to say whether it would be more trouble to figure
that out, or to just deal with the occasional regression (I guess 5
times in 6 years isn't all *that* bad...)