Re: [libvirt] [libvirt PATCH v2 43/44] Deprecate QEMU_CAPS_DISPLAY
On Mon, 2018-04-09 at 17:27 +0200, Ján Tomko wrote:
diff --git a/tests/qemuxml2argvtest.c b/tests/qemuxml2argvtest.c
index b4a36d7de7..b6b0b61ee5 100644
--- a/tests/qemuxml2argvtest.c
+++ b/tests/qemuxml2argvtest.c
@@ -1109,8 +1109,7 @@ mymain(void)
DO_TEST("graphics-sdl-fullscreen",
QEMU_CAPS_DEVICE_CIRRUS_VGA);
DO_TEST("nographics", NONE);
- DO_TEST("nographics-display",
- QEMU_CAPS_DISPLAY);
+ DO_TEST("nographics-display", NONE);
DO_TEST("nographics-vga", NONE);
None of these three seems to be testing anything, really. At least
not anymore. I'd just get rid of them.
diff --git a/tests/qemuxml2xmltest.c b/tests/qemuxml2xmltest.c
index ac01288cf0..ec107415b3 100644
--- a/tests/qemuxml2xmltest.c
+++ b/tests/qemuxml2xmltest.c
@@ -425,8 +425,7 @@ mymain(void)
DO_TEST("graphics-spice-auto-socket-cfg", NONE);
cfg->spiceAutoUnixSocket = false;
- DO_TEST("nographics-vga",
- QEMU_CAPS_DISPLAY);
+ DO_TEST("nographics-vga", NONE);
Same here, of course.
Reviewed-by: Andrea Bolognani <abologna(a)redhat.com>
--
Andrea Bolognani / Red Hat / Virtualization