Re: [libvirt] [PATCH v2 5/6] virsh: Report errors from stream callbacks

On 06/01/2017 03:39 PM, Daniel P. Berrange wrote: > On Thu, Jun 01, 2017 at 02:02:13PM +0200, Michal Privoznik wrote: >> There are couple of callbacks we pass to virStreamSendAll(), >> virStreamRecvAll() or its sparse variants. However, none of these >> callbacks reports error if one occurs and neither do the >> virStream* functions leaving user with very unhelpful error >> message: >> >> error: cannot receive data from volume fedora.img >> error: An error occurred, but the cause is unknown > > If we change the code to honour errno set in the callbacks, > we only need to deal with ensuring virFileInData sets > the errno correctly. Okay, makes sense. Will post v3. Meanwhile, do you have any clever idea on this? https://www.redhat.com/archives/libvir-list/2017-June/msg00015.html