Re: [libvirt] [PATCH 04/10] cleanup: Don't include libvirt/virterror.h

On 04/16/2013 07:41 AM, Osier Yang wrote: > Which is already included in "internal.h", later patch will add > syntax-check to avoid it. > --- > src/remote/remote_driver.h | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/src/remote/remote_driver.h b/src/remote/remote_driver.h > index 7288381..bd907c0 100644 > --- a/src/remote/remote_driver.h > +++ b/src/remote/remote_driver.h > @@ -24,8 +24,6 @@ > #ifndef __VIR_REMOTE_INTERNAL_H__ > # define __VIR_REMOTE_INTERNAL_H__ > > -# include "libvirt/virterror.h" > - > # include "configmake.h" Except that none of the remaining includes pull in internal.h, so this change would make the header not self-contained. I'd be happier if you did s#libvirt/virterror.h#internal.h# instead of deleting the line. ACK with that change.