Re: [libvirt] [PATCH 2/7] tests: qemuxml2xml: Remove testing with allowed format detection

On 03/02/2018 11:56 AM, Peter Krempa wrote: > Nobody should use format detection due to security implications. While I cannot disagree technically - would it be "useful" from a code coverage viewpoint to have just "one" do the allowDiskFormatProbing assignment similar to how various *TLS assignments are done in the qemuxml2argvtest.c? With the appropriate comment regarding the security

implications of format testing. Doesn't matter which one - just choose one and don't have the output file altered. Of course that'll be the *one* test that everyone copies to create their xml2xml tests ;-) Might be useful to note in the commit message that disabling resulted in (I assume) default output of "<driver name='qemu' type='raw'/>" being added to outputs for disks and "<format type='raw'/>" for mirrors... All the input files that changed are just targets of links for output files. > > Signed-off-by: Peter Krempa <pkrempa(a)redhat.com&gt; > ---

> diff --git a/tests/qemuxml2xmloutdata/disk-mirror-old.xml b/tests/qemuxml2xmloutdata/disk-mirror-old.xml > index e390bc02f2..f8a885aec8 100644 > --- a/tests/qemuxml2xmloutdata/disk-mirror-old.xml > +++ b/tests/qemuxml2xmloutdata/disk-mirror-old.xml > @@ -15,15 +15,18 @@ > <devices> > <emulator>/usr/bin/qemu-system-i686</emulator> > <disk type='block' device='disk'> > + <driver name='qemu' type='raw'/> > <source dev='/dev/HostVG/QEMUGuest1'/> > <backingStore/> > - <mirror type='file' file='/dev/HostVG/QEMUGuest1Copy' job='copy' ready='yes'> > + <mirror type='file' file='/dev/HostVG/QEMUGuest1Copy' format='raw' job='copy' ready='yes'> > + <format type='raw'/> Interesting that "format type='raw'" essentially appears twice... Does this point out a bug in virDomainDiskDefFormat when printing <mirror...> as formatStr is printed twice.