Re: [PATCH v2 32/34] syms: admin: Add sections to match when API was introduced
On Thu, Apr 14, 2022 at 22:47:43 +0200, Victor Toso wrote:
Discover this mismatch with the docstring work.
scripts/apibuild.py complained.
Signed-off-by: Victor Toso <victortoso(a)redhat.com>
---
src/admin/libvirt_admin_public.syms | 58 ++++++++++++++++++++++-------
1 file changed, 45 insertions(+), 13 deletions(-)
As noted in the reply to the cover letter:
NACK, this breaks existing builds of apps which link against the admin
client library:
$ gcc -lvirt -lvirt-admin -o vc libvirt/examples/c/admin/client_limits.c
$ ./vc asdf
libvirt: XML-RPC error : Failed to connect socket to
'/run/user/1000/libvirt/libvirt-admin-sock': No such file or directory
$ LD_LIBRARY_PATH=/home/pipo/build/libvirt/gcc/src ./vc asdf
./vc: symbol lookup error: ./vc: undefined symbol: virAdmConnectOpen, version
LIBVIRT_ADMIN_2.0.0