Re: [libvirt] [PATCH 2/2] Network: Add support for DNS hosts definition

oneOrMore hostname elements seems preferrable. You can use fopen and fprintf. This function also should be in src/util/dnsmasq.c (e.g. with addnhost* APIs in that file and dnsmasqAddHost as a public API). See the hostsfile* APIs there. Then you could further split the patch this way: - one patch that moves the creation of the dnsmasqContext into networkSaveDnsmasqHostsfile; - one patch that makes src/util/dnsmasq.c create the hostsfile only after the first call to dnsmasqAddDhcpHost - this would be the third patch in the series, and it would add dnsmasqAddHost calls in networkSaveDnsmasqHostsfile Uhm, libvirt has no tests that actually check whether the dnsmasq command line works? That's a bit bad, perhaps you can add them... Paolo