Re: [libvirt] [PATCHv3] qemu: fix unsuitable error report when get memory stats
On Wed, Jun 03, 2015 at 09:07:49AM +0800, Wang Yufei wrote:
From: Zhang Bo <oscar.zhangbo(a)huawei.com>
when we run the command 'virsh dommemstat xxx',
althrough memballoon's model is set 'none' in vm's XML,
it still reports an error in libvirtd.log.
error : qemuMonitorFindBalloonObjectPath:1042 : internal error: Cannot determine balloon
device path
Apparently, if we don't set memballoon, we don't need to
set balloon device path.
We shouldn't even be calling qemuMonitorFindBalloonObjectPath if there
is no balloon device.
I have sent a patch that moves the check to qemuDomainMemoryStats as a
part of a larger series:
https://www.redhat.com/archives/libvir-list/2015-June/msg00213.html
Jan
Signed-off-by: Wang Yufei <james.wangyufei(a)huawei.com>
Signed-off-by: Zhang Bo <oscar.zhangbo(a)huawei.com>
---
src/qemu/qemu_monitor.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
Attachments:
- signature.asc (application/pgp-signature — 819 bytes)