Re: [PATCH 2/2] qemu: format address wdith on intel-iommu command line

On Thu, Jun 04, 2020 at 11:34:52 +0200, Menno Lageman wrote: > On 04/06/2020 10:38, Peter Krempa wrote: >> On Thu, Jun 04, 2020 at 09:42:43 +0200, Menno Lageman wrote: >>> Format the address width attribute. Depending on the version of >>> QEMU it is named 'aw-bits' or 'x-aw-bits'. >>> >>> Signed-off-by: Menno Lageman <menno.lageman(a)oracle.com&gt; >>> --- >>> src/qemu/qemu_capabilities.c | 6 ++++ >>> src/qemu/qemu_capabilities.h | 4 +++ >>> src/qemu/qemu_command.c | 6 ++++ >>> src/qemu/qemu_validate.c | 9 ++++- >>> .../caps_2.12.0.x86_64.xml | 1 + >>> .../caps_3.0.0.x86_64.xml | 1 + >>> .../caps_3.1.0.x86_64.xml | 1 + >>> .../caps_4.0.0.x86_64.xml | 1 + >>> .../caps_4.1.0.x86_64.xml | 1 + >>> .../caps_4.2.0.x86_64.xml | 1 + >>> .../caps_5.0.0.x86_64.xml | 1 + >>> .../caps_5.1.0.x86_64.xml | 1 + >>> .../intel-iommu-aw-bits.x86_64-latest.args | 33 +++++++++++++++++++ >>> tests/qemuxml2argvtest.c | 1 + >>> 14 files changed, 66 insertions(+), 1 deletion(-) >>> create mode 100644 tests/qemuxml2argvdata/intel-iommu-aw-bits.x86_64-latest.args >>> >>> diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c >>> index f12769635a86..fa305bf67f33 100644 >>> --- a/src/qemu/qemu_capabilities.c >>> +++ b/src/qemu/qemu_capabilities.c >>> @@ -582,6 +582,10 @@ VIR_ENUM_IMPL(virQEMUCaps, >>> "tcg", >>> "virtio-blk-pci.scsi.default.disabled", >>> "pvscsi", >>> + >>> + /* 370 */ >>> + "intel-iommu.x-aw-bits", >> >> We definitely don't want to expose anythign with the experimental >> prefix. >> >>> + "intel-iommu.aw-bits", >> >> This is okay. >> > > Ok, I'll remove x-aw-bits in v2. For now there probably isn't a need to send a v2. The reviewer can remove those bits before pushing if it's simple enough.

> Is this 'we don't want to expose experimental stuff' documented somewhere I > should have read? I'm not sure if we explicitly document this somewhere. In general qemu's stance is that they can remove or modify anything x-prefixed at any time and we don't want to add support for such things until it's considered stable by qemu.