Re: [libvirt] [PATCH v2 0/2] qemu: Fix stalls during live core dump

On 02/07/2012 05:17 AM, Jiri Denemark wrote: > Qemu uses non-blocking I/O which doesn't play nice with regular file > descriptors. We need to pass a pipe to qemu when dumping core to avoid > stalls in live mode. > > Version 2: > - generalize virFileDirectFd a bit more as suggested by Eric > > Jiri Denemark (2): > util: Generalize virFileDirectFd > qemu: Always use iohelper for dumping domain core > > src/qemu/qemu_driver.c | 45 +++++++++++-------- > src/util/virfile.c | 118 +++++++++++++++++++++++++++++------------------- > src/util/virfile.h | 21 ++++++--- > 3 files changed, 112 insertions(+), 72 deletions(-) ACK series. I'm still not sure whether 'virsh save' needs EAGAIN wrapping, but I'm okay delaying that to a separate patch, since you convinced me that the primary driving factor for this patch is 'virsh dump --live' where qemu will continue on after the dump.