Re: [libvirt] [PATCH] Added timestamps to volumes

On 07/10/2012 05:52 AM, Hendrik Schwartke wrote: Incomplete. You must also document this in docs/formatstorage.html.in before this patch can be applied. Sounds interesting. Should we also list birth-time, which is available from some filesystems as a fourth timestamp? On BSD and Cygwin, birthtime is available as part of stat(); on Linux, you still have to use ioctl() or wait for the proposed xstat() interface to ever be finalized, and even then, not all file systems track that information, so it would have to be an optional element. I also think we need to track things to full precision, as in seconds + nanoseconds since epoch. That is, a proper timestamp would look like 1341925773.351768083 on a file system with full 9-digit sub-second resolution. Space after comma, throughout the patch. Store this as struct timespec, to match the POSIX definition of st_atim having both seconds and nanoseconds as part of stat() (oh phooey - the gnulib module stat-time for portably getting at nanoseconds is currently LGPLv3+; I'll see about whether we can get that relaxed). -- Eric Blake eblake(a)redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org