Re: [libvirt] [PATCH v2 00/15] Move qemu command line controller checks to qemuDomainDeviceDefValidateController* checks
On 12/06/2017 10:27 AM, John Ferlan wrote:
v1:
https://www.redhat.com/archives/libvir-list/2017-December/msg00079.html
Changes since v1:
* Remove USB from the pile of things to move. That simplifies the
Skip helper to remove the @flags argument.
Even though it seems there was some sort of objection to Skip'ing
during Validation I left that call in place since I feel it's better
to have one common function rather than cutting out each individual
check and placing it into the various ValidateController{IDE|PCI|SATA}
helpers. Having two places to maintain such checks is less optimal
in my viewpoint.
* Be sure to Unref qemuCaps in patch 4
Based on Jan's most recent response to my v1:
https://www.redhat.com/archives/libvir-list/2017-December/msg00190.html
I'll SNACK this series... I've reworked things to not have a common Skip
helper, but rather add the various skip logic to the IDE, PCI, and SATA
validate functions. I'll also push the 3 patches that were ACK'd from
v1 and then post a v3.
John
John Ferlan (12):
qemu: Introduce qemuDomainDeviceDefValidateController
qemu: Introduce qemuDomainDeviceDefSkipController
qemu: Use virDomainControllerType in qemuBuildControllerDevStr switch
qemu: Move CCW S390 Address check to controller def validate
qemu: Introduce qemuDomainDeviceDefValidateControllerSCSI
qemu: Introduce qemuDomainDeviceDefValidateControllerPCI
qemu: Use virDomainPCIControllerOpts in qemuBuildControllerDevStr
qemu: Move PCI command modelName check to controller def validate
qemu: Move PCI command modelName TypeToString to controller def
validate
qemu: Move PCI more command checks to controller def validate
qemu: Complete PCI command checks to controller def validate
qemu: Introduce qemuDomainDeviceDefValidateControllerSATA
Lin Ma (3):
tests: Remove use of IDE disk for pseries floppy test
tests: Drop IDE controller in CCW
qemu: Introduce qemuDomainDeviceDefValidateControllerIDE
src/qemu/qemu_command.c | 467 ++------------------
src/qemu/qemu_domain.c | 483 ++++++++++++++++++++-
src/qemu/qemu_domain.h | 4 +
.../qemuhotplug-base-ccw-live+ccw-virtio.xml | 4 -
...ive-with-2-ccw-virtio+ccw-virtio-1-explicit.xml | 4 -
...live-with-2-ccw-virtio+ccw-virtio-1-reverse.xml | 4 -
...qemuhotplug-base-ccw-live-with-2-ccw-virtio.xml | 4 -
...-live-with-ccw-virtio+ccw-virtio-2-explicit.xml | 4 -
...-base-ccw-live-with-ccw-virtio+ccw-virtio-2.xml | 4 -
.../qemuhotplug-base-ccw-live-with-ccw-virtio.xml | 4 -
.../qemuhotplug-base-ccw-live.xml | 4 -
tests/qemumemlocktest.c | 14 +
tests/qemuxml2argvdata/disk-floppy-pseries.args | 24 -
tests/qemuxml2argvdata/disk-floppy-pseries.xml | 7 -
tests/qemuxml2xmltest.c | 5 +-
15 files changed, 549 insertions(+), 487 deletions(-)
delete mode 100644 tests/qemuxml2argvdata/disk-floppy-pseries.args