Re: [libvirt] [PATCH 3/3] tests: optparse: Use --config with the setmaxmem command
On Thu, Jul 25, 2019 at 10:38:42AM +0200, Ján Tomko wrote:
On Thu, Jul 25, 2019 at 10:19:40AM +0200, Erik Skultety wrote:
> The virsh-optparse test broke after commit @6ac402c456a because it
And here.
> always assumed the max memory limit can be adjusted on a running domain
> which used to be the case in the old code.
> This is only a hot fix for the CI build. The proper fix here is to
> re-write the whole test in a self-test/unit-test manner where we only
> test virsh's ability to parse various values, not running actual
> commands.
>
Yes, this test is strange.
> Signed-off-by: Erik Skultety <eskultet(a)redhat.com>
> ---
> tests/virsh-optparse | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
Reviewed-by: Ján Tomko <jtomko(a)redhat.com>
Jano
Fixed and pushed all of them.
Thanks,
Erik