Re: [libvirt] [PATCH v2 0/2] add debugcon-isa chardev guest interface

On Thu, Feb 07, 2019 at 02:31:47PM +0300, Nikolay Shirokovskiy wrote: > Diff from v1 [1]: > ================= > - expose the device as serial device instead of channel in config > > I use isa-debugcon name becase libvirt passes these names to qemu as-is > so I don't want to make exception for this device. > There should be no pressure to maintain the 1:1 mapping. For QEMU, the devices need to be represented in single namespace, so they have to include the bus. In libvirt, we already have the serial type and the <address> element. It does not have to be duplicated in the model name as well.

> First version discussion: > [1] https://www.redhat.com/archives/libvir-list/2019-January/msg00951.html > > Nikolay Shirokovskiy (2): >  conf: add debugcon chardev guest interface >  qemu: implement debugcon-isa chardev > > docs/formatdomain.html.in                        |  3 +- > docs/schemas/domaincommon.rng                    |  1 + > src/conf/domain_conf.c                           |  4 +++ > src/conf/domain_conf.h                           |  1 + > src/qemu/qemu_command.c                          | 10 ++++-- > src/qemu/qemu_domain.c                           |  3 ++ > tests/qemuxml2argvdata/isa-serial-debugcon.args  | 29 ++++++++++++++++ > tests/qemuxml2argvdata/isa-serial-debugcon.xml   | 36 ++++++++++++++++++++ > tests/qemuxml2argvtest.c                         |  1 + > tests/qemuxml2xmloutdata/isa-serial-debugcon.xml | 43 ++++++++++++++++++++++++ > tests/qemuxml2xmltest.c                          |  2 ++ > 11 files changed, 129 insertions(+), 4 deletions(-) > create mode 100644 tests/qemuxml2argvdata/isa-serial-debugcon.args > create mode 100644 tests/qemuxml2argvdata/isa-serial-debugcon.xml > create mode 100644 tests/qemuxml2xmloutdata/isa-serial-debugcon.xml > > --  > 1.8.3.1 > > -- > libvir-list mailing list > libvir-list(a)redhat.com > https://www.redhat.com/mailman/listinfo/libvir-list