Re: [libvirt] [PATCH v3 3/5] virsh: expose new active commit controls

On 06/19/14 01:22, Eric Blake wrote: > Add knobs to virsh to manage a 2-phase active commit of the top > layer, similar to knobs already present on blockcopy. While this > code will fail until later patches actually implement the new > knobs in the qemu driver, doing it now proves that the API is > usable and also makes it easier for testing the qemu changes as > they are made. > > * tools/virsh-domain.c (cmdBlockCommit): Add --active, --pivot, > and --finish options, modeled after blockcopy. > (blockJobImpl): Support --active flag. > * tools/virsh.pod (blockcommit): Document new flags. > (blockjob): Mention 2-phase commit interaction. > > Signed-off-by: Eric Blake <eblake(a)redhat.com&gt; > --- > tools/virsh-domain.c | 56 ++++++++++++++++++++++++++++++++++++++++++++++------ > tools/virsh.pod | 32 +++++++++++++++++++++--------- > 2 files changed, 73 insertions(+), 15 deletions(-) > This doesn't depend on anything qemu-specific and thus is safe to push async. ACK.