On Wed, May 25, 2011 at 04:54:43PM +0800, Hu Tao wrote:
This series enables user to change memory parameters for inactive
domains from virsh command line.
This series is rebased on the latest git tree since patch 2 of the
previous sent series is applied wrongly by git on the latest git tree.
Hu Tao (3):
Add new flags for setting memory parameters
update qemuDomainGetMemoryParameters to use flags
update qemuDomainSetMemoryParameters to use flags
include/libvirt/libvirt.h.in | 7 ++
src/qemu/qemu_driver.c | 206 +++++++++++++++++++++++++++++++++---------
tools/virsh.c | 26 +++++-
tools/virsh.pod | 7 ++
4 files changed, 199 insertions(+), 47 deletions(-)
Okay, the code it relatively simple, and looks fine to me, ACK,
I wonder if somehow we should not unify the
PARAM_CURRENT/PARAM_LIVE/PARAM_CONFIG flags already present in a couple
of place to avoid duplicating the enums and making sure we have coherent
values for all the APIs. But it's an incremental improvement which can
be added as a separate step,
Daniel
--
Daniel Veillard | libxml Gnome XML XSLT toolkit
http://xmlsoft.org/
daniel(a)veillard.com | Rpmfind RPM search engine
http://rpmfind.net/
http://veillard.com/ | virtualization library
http://libvirt.org/