Re: [libvirt] if_bridge.h: include in6.h for struct in6_addr use

On 01/13/2013 01:05 PM, Thomas Backlund wrote: > Thomas Backlund skrev 13.1.2013 20:38: >> patch both inline and attached as thunderbird tends to mess up ... > >> ----- >> >> if_bridge.h uses struct in6_addr ip6; but does not include the in6.h >> header. >> >> Found by trying to build libvirt and connman against 3.8-rc3 headers. >> > > Ok, > ignore this patch, it's not the correct fix as it introduces > redefinitions... > > Btw, the error that I hit that made me suggest this fix was libvirt > config check bailing out: > > config.log:/usr/include/linux/if_bridge.h:173:20: error: field 'ip6' has > incomplete type Hmm, just now noticing this thread, after independently hitting and and having to work around the same problem in libvirt: https://www.redhat.com/archives/libvir-list/2013-January/msg00930.html https://bugzilla.redhat.com/show_bug.cgi?id=895141 >> --- linux-3.8-rc3/include/uapi/linux/if_bridge.h 2013-01-13 >> 20:09:54.257271755 +0200 >> +++ linux-3.8-rc3.fix/include/uapi/linux/if_bridge.h 2013-01-13 >> 20:15:04.153676151 +0200 >> @@ -14,6 +14,7 @@ >> #define _UAPI_LINUX_IF_BRIDGE_H >> >> #include <linux/types.h> >> +#include <linux/in6.h> >>