Re: Re: [PATCH v2 0/5] Support crypto device

On 1/25/23 02:57, zhenwei pi wrote: > > > On 1/25/23 01:08, Michal Prívozník wrote: >> On 1/17/23 02:46, zhenwei pi wrote: >>> v1 -> v2: >>> - Rebase code against the latest commit: >>>    46aee2a9255adf842ab44a9292acb46189a726f7 >>> - Merge previous 1/7 and 2/7 into a single patch: >>>    conf: introduce crypto device >>> - Add missing qemuxml2xmltest. >>> - Merge previous 3/7 and 4/7 into a single patch: >>>    capabilities: introduce crypto >>> - Add missing formatdomaincaps.rst. >>> - Several fixes from Michal Prívozník' crypto_review branch. >>> - Add caps and test for qemu-8.0. >>> >>> Thanks to Michal for lots of suggestions! >>> >>> v1: >>> This series supports crypto device, also add support for QEMU. >>> The basic xml schema looks like: >>>        <crypto model='virtio' type='qemu'> >>>          <backend model='builtin' queues='1'/> >>>          <address type='pci' domain='0x0000' bus='0x00' slot='0x0a' >>> function='0x0'/> >>>        </crypto> >>> >>>        <crypto model='virtio' type='qemu'> >>>          <backend model='lkcf'/> >>>          <address type='pci' domain='0x0000' bus='0x00' slot='0x0b' >>> function='0x0'/> >>>        </crypto> >>> >>> Each patch has been tested by 'ninja -C build test', and launch a QEMU >>> with crypto devices, it works fine. >>> >>> zhenwei pi (5): >>>    conf: introduce crypto device >>>    capabilities: introduce crypto >>>    qemu: alias: support crypto device >>>    qemu: command: support crypto device >>>    NEWS: Document 'crypto' device >> >> And we're almost there. This is way better version already. And >> depending on your answers, I'd merge these. Please see individual >> comments. No need to resend just now, it's all small nits that I can fix >> before pushing. >> >> To imagine changes I'm suggesting easier, I've uploaded fixup commits >> onto my gitlab: >> >> https://gitlab.com/MichalPrivoznik/libvirt/-/commits/review_crypto/ >> >> Please take a look and if you agree, I'll squash those commits in and >> push. >> >> Michal >> > > Hi Michal > > Thanks! I have only one concern, and reply in *[PATCH v2 4/5] qemu: > command: support crypto device*, Otherwise agree with your changes. > Perfect! Reviewed-by: Michal Privoznik <mprivozn(a)redhat.com&gt; and merged.