Re: [PATCH 2/3] fdc: Inline fdctrl_connect_drives() into fdctrl_realize_common()

Am 25.01.2021 um 17:24 hat Markus Armbruster geschrieben: > The previous commit rendered the name fdctrl_realize_common() somewhat > misleading. Get rid of it by inlining the (now pretty simple) > function into its only caller. > > Signed-off-by: Markus Armbruster <armbru(a)redhat.com&gt; > --- > hw/block/fdc.c | 23 ++++++++--------------- > 1 file changed, 8 insertions(+), 15 deletions(-) > > diff --git a/hw/block/fdc.c b/hw/block/fdc.c > index c6c9393e29..7fc547c62d 100644 > --- a/hw/block/fdc.c > +++ b/hw/block/fdc.c > @@ -2521,20 +2521,6 @@ void isa_fdc_init_drives(ISADevice *fdc, DriveInfo **fds) > fdctrl_init_drives(&ISA_FDC(fdc)->state.bus, fds); > } > > -static void fdctrl_connect_drives(FDCtrl *fdctrl, DeviceState *fdc_dev, > - Error **errp) The commit message talks about fdctrl_realize_common(). I assume it really means fdctrl_connect_drives() then?