Re: [PATCH 5/8] qemu: snapshot: Change 'data-file' to read-only after snapshot

On Tue, Nov 26, 2024 at 16:16:16 +0100, Peter Krempa wrote: > For the reason outlined in previous commit qemu doesn't do this > automatically. Handle it manually after the snapshot. > > Signed-off-by: Peter Krempa <pkrempa(a)redhat.com&gt; > --- > src/qemu/qemu_snapshot.c | 12 ++++++++++-- > 1 file changed, 10 insertions(+), 2 deletions(-) > > diff --git a/src/qemu/qemu_snapshot.c b/src/qemu/qemu_snapshot.c > index 5b3aadcbf0..f880d1eeec 100644 > --- a/src/qemu/qemu_snapshot.c > +++ b/src/qemu/qemu_snapshot.c ... > @@ -1470,6 +1477,7 @@ qemuSnapshotDiskUpdateSource(virDomainObj *vm, > dd->persistsrc->backingStore = g_steal_pointer(&dd->persistdisk->src); > dd->persistdisk->src = g_steal_pointer(&dd->persistsrc); > } > + > } Looks like an accidental change, which was not supposed to be included in the commit.