Re: [libvirt] [PATCH] Fix ejecting cdroms with latest qemu syntax

+ + int idx = virDiskNameToIndex(newdisk->dst); + switch (newdisk->bus) { + /* Assume that if we are here, device targets don't exceed hypervisor + * limits, and we are already an appropriate device type */ + case VIR_DOMAIN_DISK_BUS_IDE: + /* Device name of the form 'ide{0-1}-cd{0-1}' */ + ret = asprintf(&devname, "ide%d-cd%d", ((idx - (idx % 2)) / 2), + (idx % 2)); + break; + case VIR_DOMAIN_DISK_BUS_SCSI: + /* Device name of the form 'scsi{bus#}-cd{0-6} + * Each bus holds seven devs */ + ret = asprintf(&devname, "scsi%d-cd%d", ((idx - (idx % 7)) / 7), + (idx % 7)); + break; + case VIR_DOMAIN_DISK_BUS_FDC: + /* Device name is 'floppy{0-1}' */ + ret = asprintf(&devname, "floppy%d", idx); + break; + + default: + qemudReportError(dom->conn, dom, NULL, VIR_ERR_NO_SUPPORT, + _("Cannot hotplug device with bus '%s'"), + virDomainDiskBusTypeToString(newdisk->bus)); + return -1; + }