Re: [libvirt] [PATCH v2 2/3] Add test case for virHashEqual function
On 01/20/2012 07:16 PM, Eric Blake wrote:
On 01/18/2012 09:20 AM, Stefan Berger wrote:
> Add a test case to test the virHashEqual function.
>
> ---
> tests/hashtest.c | 78 +++++++++++++++++++++++++++++++++++++++++++++++++++++++
> 1 file changed, 78 insertions(+)
Even better - you test your new API. I would have squashed this into
1/3, but separate patches is okay as well.
> static int
> +testHashEqualCompValue(const void *value1, const void *value2)
> +{
> + return strcmp (value1, value2);
Style: no space before (.
c&p from the test case above...
Suggestion - maybe use strcasecmp, and pass in strings that differ
in
case to prove that definitions of 'equal' data values is user-defined.
I changed that to use c_strcasecmp() with values having different case.
Pushed. Thanks.
Stefan