Re: [libvirt] [PATCH 3/5] Introduce functions for checking whether a pidfile is valid

12 Aug 2011


      On Fri, Aug 12, 2011 at 14:46:35 +0100, Daniel P. Berrange wrote:
...
On Fri, Aug 12, 2011 at 02:10:00PM +0200, Jiri Denemark wrote:
...
...
...
+    if (virAsprintf(&procpath, "/proc/%d/exe", *pid) < 0) {
+        *pid = -1;
+        return 0;
+    }
+#ifdef __linux__
+    if (virFileLinkPointsTo(procpath, binpath) == 0)
+        *pid = -1;
+#endif
+   VIR_FREE(procpath);
Indentation.
What's wrong with indentation ??
There are three (not four) spaces in front of VIR_FREE().

Jirka