Re: [libvirt] [PATCH 10/20] test: rename defaultConn to defaultPrivconn

On 03/08/2018 07:20 AM, Marc Hartmayer wrote: > Rename the variable @defaultConn to @defaultPrivconn as it doesn't > point to a default connection but to the private data used for the > shared default connection of the test driver. > > Signed-off-by: Marc Hartmayer <mhartmay(a)linux.vnet.ibm.com&gt; > Reviewed-by: Boris Fiuczynski <fiuczy(a)linux.vnet.ibm.com&gt; > --- > src/test/test_driver.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/src/test/test_driver.c b/src/test/test_driver.c > index 5561d0c2ae70..d450be21704e 100644 > --- a/src/test/test_driver.c > +++ b/src/test/test_driver.c > @@ -126,7 +126,7 @@ struct _testDriver { > typedef struct _testDriver testDriver; > typedef testDriver *testDriverPtr; > > -static testDriverPtr defaultConn; > +static testDriverPtr defaultPrivconn; Probably should be defaultPrivateData then instead since it's assigned to conn->privateData...

(I can change locally before doing any sort of push as long as you agree)... Reviewed-by: John Ferlan <jferlan(a)redhat.com&gt; John