Re: [libvirt] [libvirt-python] [PATCH 0/2] Add tox.ini to run tests with tox
Is it also worth hooking this into the Makefile, so that the
existing
'make check' also runs tox?
I have no opinion on that :-) I don't know how other developers are testing
libvirt-python.
"python setup.py test" tests /usr/bin/python" (usually Python 2.7) and it
doesn't install dependencies. It might be faster than tox.
"tox" tests Python 2.6, 2.7 and 3.4 at once and it installs dependencies. But it
requires the external tox program (install it using "pip install tox").
Also, please run 'git config format.subjectprefix "python
PATCH"' to
make it obvious that your patches are against libvirt-python.git instead
of libvirt.git.
Yeah sorry, it was the first time that I used git format-patch/git send-email for real!
I missed the fact that the mailing list is for multiple projects. I will mention
"python" in the topic next time ;-)
(I already added "libvirt-python" for my setup.py patch.)
Victor