Re: [libvirt] [PATCH 2/4] Fix snapshot-create-as syntax in help output

On 03/14/2013 11:16 AM, Daniel P. Berrange wrote: > On Thu, Mar 14, 2013 at 10:27:33AM +0100, Martin Kletzander wrote: >> According to the man page, the memspec parameter should have the >> '--memspec' option mandatory and this is as close as we can get to >> that. What this change does is explained below. >> >> >> diff --git a/tools/virsh-snapshot.c b/tools/virsh-snapshot.c >> index d994fd9..c2db99b 100644 >> --- a/tools/virsh-snapshot.c >> +++ b/tools/virsh-snapshot.c >> @@ -397,7 +397,7 @@ static const vshCmdOptDef opts_snapshot_create_as[] = { >> .help = N_("take a live snapshot") >> }, >> {.name = "memspec", >> - .type = VSH_OT_DATA, >> + .type = VSH_OT_STRING, >> .flags = VSH_OFLAG_REQ_OPT, >> .help = N_("memory attributes: [file=]name[,snapshot=type]") >> }, > > ACK, looks reasonable, but would like Eric to confirm since he did > this bit of code. Concur - this is a reasonable change. (I'm still not sure why we have VSH_OT_DATA vs. VSH_OT_STRING, as about the ONLY place where they make a difference is in help ouput.)