Re: [libvirt] [PATCH 17/20] cpu_map.xml: Expand Haswell-noTSX CPU model
On Thu, Jul 02, 2015 at 09:31:19 +0200, Peter Krempa wrote:
On Thu, Jul 02, 2015 at 09:26:11 +0200, Peter Krempa wrote:
> On Fri, Jun 26, 2015 at 15:17:16 +0200, Jiri Denemark wrote:
> > Inheritance among CPU model is cool but it makes reviewing CPU model
> > definitions and comparing them to CPU models from QEMU rather hard and
> > unpleasant. Let's define all CPU models from scratch.
> >
> > Signed-off-by: Jiri Denemark <jdenemar(a)redhat.com>
> > ---
> > src/cpu/cpu_map.xml | 50 +++++++++++++++++++++++++++++++++++++++++++++++++-
> > 1 file changed, 49 insertions(+), 1 deletion(-)
>
> ACK
Actually either the commit message or your intention is wrong since this
patch does not expand <model name='Haswell'> which inherits from <model
name='Haswell-noTSX'/>. So the ACK is retracted.
It is intentional, although I forgot to mention it in the commit
message. Haswell{,-noTSX} are basically just different revisions of the
same CPU so it kind of makes sense to keep on of them reference the
other one. On the other hand, it still makes comparing models harder so
I will send a v2 which will expand everything.
Jirka