Re: [libvirt] [PATCHv2 variant 1] snapshot: implement new APIs for esx and vbox

2012/6/12 Eric Blake <eblake(a)redhat.com&gt;: > The two new APIs are rather trivial; based on bits and pieces of > other existing APIs. But rather than blindly return 0 or 1 for > HasMetadata, I chose to first validate that the snapshot in > question in fact exists. In the process, I noticed other APIs > that were blindly succeeding instead of checking for existence. > > * src/esx/esx_driver.c (esxDomainSnapshotIsCurrent) > (esxDomainSnapshotHasMetadata): New functions. > (esxDomainIsUpdated, esxDomainIsPersistent): Add existence checks. > * src/vbox/vbox_tmpl.c (vboxDomainSnapshotIsCurrent) > (vboxDomainSnapshotHasMetadata): New functions. > (vboxDomainIsPersistent, vboxDomainIsUpdated): Add existence checks. > --- > > v2: add existence checks to other functions > I like this version better. However, while it compiles, I'm > completely unable to runtime test it, so I'd appreciate a > good review. >

> + > +cleanup: VBOX_RELEASE(snap); is missing here.

> + VBOX_RELEASE(machine); > + vboxIIDUnalloc(&iid); > + return ret; > +} Tested and works. ACK.