Re: [libvirt] [PATCHv5 7/7] qemu: snapshot: Add support for external active snapshots on gluster

On 02/11/2014 09:26 AM, Peter Krempa wrote: > Add support for gluster backed images as sources for snapshots in the > qemu driver. This will also simplify adding further network backed > volumes as sources for snapshot in case qemu will support them. > --- > Looks a bit confusing the number of variables we have to track as we swap between original and new, then fallback or commit. But I didn't spot anything obviously wrong in how you did it. I suspect that if we ever convert over to having domain XML track full backing chain semantics, we will have a lot to rewrite in this area of code to take advantage of that, but the future shouldn't hold up incremental progress in the present. ACK.