Re: [libvirt] [PATCH] Fix pthread related link error for virt-aa-helper
Eric Blake wrote:
On 05/07/2010 10:07 AM, Matthias Bolte wrote:
> Link virt-aa-helper explicitly with pthread. This is at least
> required on Ubuntu 10.04.
...
> -virt_aa_helper_LDFLAGS = $(WARN_CFLAGS)
> +virt_aa_helper_LDFLAGS = $(WARN_CFLAGS) $(LIB_PTHREAD)
ACK that adding a LIB_PTHREAD is the correct solution, but...
Aargh; sorry for not noticing this sooner, but you copied a bug from
Jim's patch, which in turn Jim copied from existing code. According to
automake, LDFLAGS is for -L and other flags that must come early in the
command line, but LDADD is for -l and other flags that must come late in
Definitely worth fixing.
the command line. It doesn't quite matter on Linux, which has
lazy
linking if you specify -l too early, but it breaks compilation on cygwin
if you get it in the wrong order.
I'm working up a followup patch that moves LIB_PTHREAD (and other libs)
out of LDFLAGS and into LDADD.
Thanks for cleaning up.