[libvirt] [PATCH] util: pci: Remove always-false condition
Commit d19c21429fd modified the condition so that it checks whether the
value is more than 0xFFFFFFFF. Since addr->domain is an unsigned int, it
will never be more than that.
Remove the whole check
src/util/virpci.c:1291:22: error: result of comparison 'unsigned int' >
4294967295 is always false [-Werror,-Wtautological-type-limit-compare]
if (addr->domain > 0xFFFFFFFF) {
~~~~~~~~~~~~ ^ ~~~~~~~~~~
Signed-off-by: Peter Krempa <pkrempa(a)redhat.com>
---
This was caught by new clang:
$ clang -v
clang version 9.0.0 (Fedora 9.0.0-1.fc31)
This "fix" is the naive approach which assumes the original patch was
correct.
src/util/virpci.c | 8 --------
1 file changed, 8 deletions(-)
diff --git a/src/util/virpci.c b/src/util/virpci.c
index f9e39e79d8..cd560d683b 100644
--- a/src/util/virpci.c
+++ b/src/util/virpci.c
@@ -1288,14 +1288,6 @@ bool
virPCIDeviceAddressIsValid(virPCIDeviceAddressPtr addr,
bool report)
{
- if (addr->domain > 0xFFFFFFFF) {
- if (report)
- virReportError(VIR_ERR_XML_ERROR,
- _("Invalid PCI address domain='0x%x', "
- "must be <= 0xFFFF"),
- addr->domain);
- return false;
- }
if (addr->bus > 0xFF) {
if (report)
virReportError(VIR_ERR_XML_ERROR,
--
2.23.0