Re: [libvirt] [PATCH] Support for qemu aio drive option

>> Does this deserve a new <iobackend> element, or should it merely be a >> new optional attribute of the existing <driver> element, as in: >> >> <driver name='qemu' type='qcow2' cache='none' iobackend='aiothreads'/> > > I slightly prefer making it a new attribute of <driver>. The only reason I > can see to make it a new <iobackend> element is if we think it will get > significantly more complex in the future (necessitating new XML elements). Do > we think that? Yep, the whole '<driver>' element is really specifying an I/O backend, so I don't think it makes sense to add another <iobackend> element, nor is it particularly great as an attribute name. It should be an attribute on <driver> though