Re: [libvirt] [PATCH] security: apparmor: Properly link with storage driver in helper program
On Tue, Jul 18, 2017 at 12:51 PM, Peter Krempa <pkrempa(a)redhat.com> wrote:
The refactor to split up storage driver into modules broke the
apparmor
helper program, since that did not initialize the storage driver
properly and thus detection of the backing chain could not work.
Register the storage driver backends explicitly. Unfortunately it's now
necessary to link with the full storage driver to satisfy dependencies
of the loadable modules.
Hi I tested:
- on master direct virt-aa-helper calls
- on Ubuntu+patch direct virt-aa-helper calls
- on Ubuntu+patch start of confined guest with disks that have BackingStores
- built for all architectures Ubuntu's libvirt supports (amd64 arm64 armhf
i386 ppc64el s390x)
All worked thanks to the patch (which was created in response to [1])
Please pick commit tags as you consider appropriate, I guess you won't need
all three, but I happily give them all to you :-)
Thanks a lot Peter!
Acked-by: Christian Ehrhardt <christian.ehrhardt(a)canonical.com>
Reported-by: Christian Ehrhardt <christian.ehrhardt(a)canonical.com>
Tested-by: Christian Ehrhardt <christian.ehrhardt(a)canonical.com>
[1]: https://www.redhat.com/archives/libvir-list/2017-July/msg00604.html
Attachments:
- attachment.html (text/html — 2.3 KB)