On 04/04/2010 11:36 AM, Matthias Bolte wrote:
Mark more messages for translation.
---
cfg.mk | 45 +++++++++++++++++++++++--------
po/POTFILES.in | 1 +
src/interface/netcf_driver.c | 60 +++++++++++++++++++++++-------------------
src/libvirt.c | 12 ++++----
src/nodeinfo.c | 2 +-
src/test/test_driver.c | 12 ++++----
src/util/stats_linux.c | 4 +-
src/xen/block_stats.c | 19 +++++++-----
tools/virsh.c | 8 +++---
9 files changed, 97 insertions(+), 66 deletions(-)
diff --git a/cfg.mk b/cfg.mk
index b87f261..d34a25e 100644
--- a/cfg.mk
+++ b/cfg.mk
@@ -168,49 +168,70 @@ sc_prohibit_gethostby:
# |grep -vE
'^(qsort|if|close|assert|fputc|free|N_|vir.*GetName|.*Unlock|virNodeListDevices|virHashRemoveEntry|freeaddrinfo|.*[fF]ree|xdrmem_create|xmlXPathFreeObject|virUUIDFormat|openvzSetProgramSentinal|polkit_action_unref)$'
msg_gen_function =
-msg_gen_function += ReportError
msg_gen_function += ESX_ERROR
msg_gen_function += ESX_VI_ERROR
-msg_gen_function += remoteError
Not to be too picky, but it would be easier to see this split into two
patches; one that sorts names, and another that adds/removes names.
+msg_gen_function += eventReportError
+msg_gen_function += interfaceReportError
msg_gen_function += lxcError
+msg_gen_function += macvtapError
msg_gen_function += networkReportError
+msg_gen_function += nodeReportError
msg_gen_function += oneError
msg_gen_function += openvzError
-msg_gen_function += qemudDispatchClientFailure
-msg_gen_function += qemudReportError
-msg_gen_function += regerror
+msg_gen_function += pciReportError
+msg_gen_function += PHYP_ERROR
msg_gen_function += remoteDispatchFormatError
+msg_gen_function += remoteError
+msg_gen_function += statsErrorFunc
+msg_gen_function += testError
msg_gen_function += umlReportError
+msg_gen_function += usbReportError
+#msg_gen_function += vboxError
This line would look better if moved down to the rest of the
commented-out diagnostics...
+msg_gen_function += virCPUReportError
msg_gen_function += virConfError
msg_gen_function += virDomainReportError
-msg_gen_function += virSecurityReportError
-msg_gen_function += virHashError
+msg_gen_function += virGenericReportError
+msg_gen_function += virHookReportError
+msg_gen_function += virInterfaceReportError
+msg_gen_function += virJSONError
msg_gen_function += virLibConnError
+msg_gen_function += virLibConnWarning
msg_gen_function += virLibDomainError
+msg_gen_function += virLibNetworkError
+msg_gen_function += virLibInterfaceError
+msg_gen_function += virLibStoragePoolError
+msg_gen_function += virLibStorageVolError
+msg_gen_function += virLibNodeDeviceError
+msg_gen_function += virLibSecretError
+msg_gen_function += virLibNWFilterError
msg_gen_function += virNetworkReportError
msg_gen_function += virNodeDeviceReportError
+msg_gen_function += virNWFilterReportError
msg_gen_function += virProxyError
msg_gen_function += virRaiseError
+msg_gen_function += virRaiseErrorFull
msg_gen_function += virReportErrorHelper
msg_gen_function += virReportSystemError
+msg_gen_function += virSecretReportError
+msg_gen_function += virSecurityReportError
msg_gen_function += virSexprError
-msg_gen_function += virStorageLog
+msg_gen_function += virStatsError
msg_gen_function += virStorageReportError
-msg_gen_function += virXMLError
+msg_gen_function += virUtilError
+msg_gen_function += virXendError
msg_gen_function += virXenInotifyError
msg_gen_function += virXenStoreError
-msg_gen_function += virXendError
-msg_gen_function += vshCloseLogFile
+msg_gen_function += virXMLError
msg_gen_function += xenapiSessionErrorHandler
msg_gen_function += xenUnifiedError
msg_gen_function += xenXMError
+
# Uncomment the following and run "make syntax-check" to see diagnostics
# that are not yet marked for translation, but that need to be rewritten
# so that they are translatable.
...here.
# msg_gen_function += error
Didn't you just get rid of the macro error() earlier in the series? I
don't see any use of glibc's <error.h>.
# msg_gen_function += fprintf
-# msg_gen_function += testError
# msg_gen_function += virXenError
# msg_gen_function += vshPrint
# msg_gen_function += vshError
And I just got called away; rest of the review later after I eat.
--
Eric Blake eblake(a)redhat.com +1-801-349-2682
Libvirt virtualization library
http://libvirt.org