Re: [libvirt] [PATCH v2 5/5] qemu: Add gl option to SDL graphics command line
On 05/10/2018 06:53 AM, Maciej Wolny wrote:
Support OpenGL when using SDL backend via -sdl,gl=on. Add associated
tests.
I'll add this here:
NB: Usage of DO_TEST_CAPS_LATEST in qemuxml2argv doesn't work in this
case because -sdl gl is not introspectable.
Signed-off-by: Maciej Wolny <maciej.wolny(a)codethink.co.uk>
---
src/qemu/qemu_command.c | 25 ++++++++++++++++++-
.../qemuxml2argvdata/video-virtio-gpu-sdl-gl.args | 28 ++++++++++++++++++++++
tests/qemuxml2argvtest.c | 5 ++++
3 files changed, 57 insertions(+), 1 deletion(-)
create mode 100644 tests/qemuxml2argvdata/video-virtio-gpu-sdl-gl.args
Reviewed-by: John Ferlan <jferlan(a)redhat.com>
John
Plz just let me know if you're OK with my patch4 adjustment. I'll push
in a couple of days anyway to ensure no one else has concerns I missed
or has a better idea of how to get that -sdl gl introspected.