Re: [libvirt] [PATCH v3 04/48] build: use a common rule for checking augeas test data files
On Mon, 2019-07-29 at 18:10 +0100, Daniel P. Berrangé wrote:
+++ b/src/Makefile.am
@@ -397,13 +396,22 @@ GENERATED_SYM_FILES += \
+AUG_TEST_NAMES = $(subst /,-, $(augeastest_DATA))
AUG_TEST_NAMES is no longer necessary.
-check-augeas: $(AUGEAS_DIRS:%=check-augeas-%)
+check-augeas: $(augeas_DATA) $(augeastest_DATA)
+ $(AM_V_GEN) \
+ if test -x "$(AUGPARSE)"; then \
+ for f in $(augeastest_DATA); do \
+ DIR=$$(dirname "$$f"); \
+ FILE=$$(basename "$$f"); \
+ "$(AUGPARSE)" \
+ -I "$(srcdir)/$$DIR" -I "$(builddir)/$$DIR" \
+ "$$DIR/$$FILE"; \
+ done; \
+ fi
+.PHONY: check-augeas
Why didn't you do for the alternative version, the one in
https://www.redhat.com/archives/libvir-list/2019-July/msg01609.html
which prints the name of each file as they are processed?
With either version of the check-augeas rule, and with AUG_TEST_NAMES
gone,
Reviewed-by: Andrea Bolognani <abologna(a)redhat.com>
--
Andrea Bolognani / Red Hat / Virtualization