Re: [libvirt] [PATCH option 1] Use fallocate directly if possible
On Tue, Mar 02, 2010 at 10:08:50AM -0700, Eric Blake wrote:
According to Daniel Veillard on 3/2/2010 9:53 AM:
>>> +#if defined(HAVE_POSIX_FALLOCATE) && !defined(HAVE_FALLOCATE)
>>
>> Redundant parenthesis. I know upstream gnulib's maint.mk warns about
>> them; did we turn them off in libvirt's 'make syntax-check'?
>
> Hum, what's redundant here ?
It's perfectly acceptable (and less typing) to do:
#if defined HAVE_POSIX_FALLOCATE && !defined HAVE_FALLOCATE
Whether it is also more legible is a matter of opinion.
Never seen the second form, and I prefer the first one personally :-)
Daniel
--
Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/
daniel(a)veillard.com | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library http://libvirt.org/