Re: [PATCH v2 7/8] Add unit test for network backed NVRAM
On Tue, Apr 26, 2022 at 16:17:42 +0530, Rohit Kumar wrote:
On 21/04/22 8:39 pm, Peter Krempa wrote:
> On Fri, Apr 08, 2022 at 10:48:50 -0700, Rohit Kumar wrote:
> > This patch adds unit test for network backed NVRAM
> >
> > Example:
> > <nvram type='network'>
> > <source protocol='iscsi'
name='iqn.2013-07.com.example:iscsi-nopool/0'>
> > <host name='example.com' port='6000'/>
> > </source>
> > </nvram>
> >
> > Signed-off-by: Prerna Saxena <prerna.saxena(a)nutanix.com>
> > Signed-off-by: Florian Schmidt <flosch(a)nutanix.com>
> > Signed-off-by: Rohit Kumar <rohit.kumar3(a)nutanix.com>
> > ---
> > .../bios-nvram-network.x86_64-latest.args | 37 +++++++++++++++++++
> > tests/qemuxml2argvdata/bios-nvram-network.xml | 25 +++++++++++++
> > tests/qemuxml2argvtest.c | 1 +
> > 3 files changed, 63 insertions(+)
> > create mode 100644
tests/qemuxml2argvdata/bios-nvram-network.x86_64-latest.args
> > create mode 100644 tests/qemuxml2argvdata/bios-nvram-network.xml
[...]
> Do you want to use this with iSCSI or did you pick this just as
an
> example?
I meant this as just an example. Having iSCSI support is enough for us, but
I think we can have support for all the other protocols as well with this
patchset.
Yes, luckily other protocols are for free due to code reuse. Just
include one more example perhaps. Unfortunately one XML can test only
one instance.
Also for iSCSI the code supports authentication, so make sure to pick an
example including authentication.