Re: [libvirt PATCH 08/31] docs: drop %.png: %.fig rule

On 7/9/20 4:59 PM, Daniel P. Berrangé wrote: > On Thu, Jul 02, 2020 at 02:25:06PM +0200, Pavel Hrdina wrote: > > convert bin is part of ImageMagick package and uses uniconvertor to > > create png file from fig files. > > > > Unfortunately uniconvertor is python2 only and not available in most > > recent distributions which makes the convert command fail with: > > > > sh: uniconvertor: command not found > > /usr/bin/mv: cannot stat '/tmp/magick-1397138DRT8Pzx4Qmoc.svg': No such file or directory > > convert: delegate failed `'uniconvertor' '%i' '%o.svg'; /usr/bin/mv '%o.svg' '%o'' @ error/delegate.c/InvokeDelegate/1958. > > convert: unable to open file `/tmp/magick-1397138S8ARueJXLXkc': No such file or directory @ error/constitute.c/ReadImage/605. > > convert: no images defined `docs/migration-managed-direct.png' @ error/convert.c/ConvertImageCommand/3226. > > > > It looks like that there are plans to somehow port uniconvertor into > > python3 but as part of different project color-picker but the job is > > far from complete. > > FYI i would support replacing the .fig files in git with .svgs > which will avoid the extra conversion step. The .fig stuff is just > too anachronistic to be worth worrying about. Actually, I think that is the right way to go instead of just removing this rule. Because if we ever change a *.fig file we have to remember to regenerate the corresponding .png file. And then we can drop .png files from our repos.