Re: [libvirt] [PATCH] network: fill in bandwidth from portgroup for all forward modes

On Tue, Oct 04, 2011 at 12:17:27AM -0400, Laine Stump wrote: > This patch is a fix for: > > https://bugzilla.redhat.com/show_bug.cgi?id=743176 > > which was discovered by Dan Berrange while making bandwidth > configuration work for LXC guests. > > Background: Although virtportprofile data from a network portgroup is > only applicable for direct mode interfaces, the code that copies > bandwidth data from the portgroup was also only being executed in the > case of direct mode interfaces. The result was that interfaces using > traditional virtual networks (forward mode='nat|route|none'), and > those using a host bridge for forwarding, would not pick up bandwidth > data from a portgroup defined in the network. > > This patch moves that code outside the conditional, so that bandwidth > information is *alway* copied from the appropriate portgroup (unless > the<interface> definition itself already has bandwidth information, > which would take precedence over what's in the portgroup anyway). ACK, this works in my test