Re: [libvirt] [PATCHv2 1/4] VMX: Add cdrom-raw dev type from VMWare Fusion

Il 27/08/2013 15:50, Daniel P. Berrange ha scritto: > On Thu, Aug 22, 2013 at 08:53:06PM -0500, Doug Goldstein wrote: >> According to VMWare's documentation 'cdrom-raw' is an acceptable value >> for deviceType for a CD-ROM drive. The documentation states that the VMX >> configuration for a CD-ROM deviceType is as follows: >> >> ide|scsi(n):(n).deviceType = "cdrom-raw|atapi-cdrom|cdrom-image" >> >> >From the documentation it appears the following is true: >> - cdrom-image = Provides the ISO to the VM >> - atapi-cdrom = Provides a NEC emulated ATAPI CD-ROM on top of the host >> CD-ROM >> - cdrom-raw = Passthru for a host CD-ROM drive. Allows CD-R burning from >> within the guest. >> >> A CD-ROM prior to this patch would always provide an 'atapi-cdrom' is >> modeled as: >> <disk type='block' device='cdrom'> >> <source dev='/dev/scd0'/> >> <target dev='hda' bus='ide'/> >> <address type='drive' controller='0' bus='0' target='0' unit='0'/> >> </disk> >> >> This patch allows an optional element as: >> <driver name='atapi'/> >> that would maintain existing behavior. While: >> <driver name='raw'/> >> would provide a 'cdrom-raw' to the VM. > > > The 'cdrom-raw' case sounds very similar to the scenario we addressed > in QEMU, by adding support for a 'lun' value in the device attribute. > > eg I think 'cdrom-raw' could be addressed by supporting > > <disk type='block' device='lun'> > <source dev='/dev/scd0'/> > <target dev='hda' bus='ide'/> > <address type='drive' controller='0' bus='0' target='0' unit='0'/> > </disk> > > rather than using <driver> > > Paolo, you added the 'lun' support - do you agree with this ? Yes, 100%. - cdrom-image is type='file' device='cdrom' - atapi-cdrom is type='block' device='cdrom' - cdrom-raw is type='block' device='lun' Paolo